Return-Path: 
 <dev-return-118-apmail-orc-dev-archive=orc.apache.org@orc.apache.org>
X-Original-To: apmail-orc-dev-archive@minotaur.apache.org
Delivered-To: apmail-orc-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 79738180C6
	for <apmail-orc-dev-archive@minotaur.apache.org>;
 Tue, 19 Jan 2016 18:53:42 +0000 (UTC)
Received: (qmail 37687 invoked by uid 500); 19 Jan 2016 18:53:42 -0000
Delivered-To: apmail-orc-dev-archive@orc.apache.org
Received: (qmail 37655 invoked by uid 500); 19 Jan 2016 18:53:42 -0000
Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@orc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@orc.apache.org>
List-Post: <mailto:dev@orc.apache.org>
List-Id: <dev.orc.apache.org>
Reply-To: dev@orc.apache.org
Delivered-To: mailing list dev@orc.apache.org
Received: (qmail 37643 invoked by uid 99); 19 Jan 2016 18:53:42 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 18:53:42 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 0D296DFCB5; Tue, 19 Jan 2016 18:53:42 +0000 (UTC)
From: omalley <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-15-orc@git.apache.org>
In-Reply-To: <git-pr-15-orc@git.apache.org>
Subject: [GitHub] orc pull request: ORC-8. Reimplement file-metadata to use
 the read...
Content-Type: text/plain
Message-Id: <20160119185342.0D296DFCB5@git1-us-west.apache.org>
Date: Tue, 19 Jan 2016 18:53:42 +0000 (UTC)

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/15#discussion_r50155968
  
    --- Diff: tools/src/FileMetadata.cc ---
    @@ -16,168 +16,162 @@
      * limitations under the License.
      */
     
    +#include <getopt.h>
     #include <iostream>
     #include <fstream>
     #include <vector>
     #include <string>
     #include <sstream>
    -#include <iomanip>
     
    -#include "wrap/orc-proto-wrapper.hh"
     #include "orc/OrcFile.hh"
     
    -using namespace orc::proto;
    -
    -uint64_t getTotalPaddingSize(const Footer& footer) {
    -  uint64_t paddedBytes = 0;
    -  StripeInformation stripe;
    -  for (int stripeIx=1; stripeIx<footer.stripes_size(); stripeIx++) {
    -      stripe = footer.stripes(stripeIx-1);
    -      uint64_t prevStripeOffset = stripe.offset();
    -      uint64_t prevStripeLen = stripe.datalength() + stripe.indexlength() +
    -        stripe.footerlength();
    -      paddedBytes += footer.stripes(stripeIx).offset() -
    -        (prevStripeOffset + prevStripeLen);
    -  };
    -  return paddedBytes;
    +void printStripeInformation(std::ostream& out,
    +                            uint64_t index,
    +                            uint64_t columns,
    +                            std::unique_ptr<orc::StripeInformation> stripe,
    +                            bool verbose) {
    +  out << "    { \"stripe\": " << index
    +      << ", \"rows\": " << stripe->getNumberOfRows() << ",\n";
    +  out << "      \"offset\": " << stripe->getOffset()
    +      << ", \"length\": " << stripe->getLength() << ",\n";
    --- End diff --
    
    The lines get really long and hard to read. I don't think we should merge those lines. I've grouped related fields together on to the same line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---