Return-Path: X-Original-To: apmail-orc-dev-archive@minotaur.apache.org Delivered-To: apmail-orc-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 924EA18B3B for ; Thu, 7 Jan 2016 17:08:59 +0000 (UTC) Received: (qmail 45843 invoked by uid 500); 7 Jan 2016 17:08:59 -0000 Delivered-To: apmail-orc-dev-archive@orc.apache.org Received: (qmail 45791 invoked by uid 500); 7 Jan 2016 17:08:59 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Delivered-To: moderator for dev@orc.apache.org Received: (qmail 57871 invoked by uid 99); 6 Jan 2016 18:38:42 -0000 From: omalley To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc pull request: ORC-29. Enable ColumnPrinter to print only selec... Content-Type: text/plain Message-Id: <20160106183841.D8292DFDC7@git1-us-west.apache.org> Date: Wed, 6 Jan 2016 18:38:41 +0000 (UTC) Github user omalley commented on the pull request: https://github.com/apache/orc/pull/9#issuecomment-169414339 Ok, I pulled out the tree climbing code into TypeImpl::ensureIdAssigned(). I updated the comments on the ReaderOptions::include methods to clarify that calling either one resets the currently selected columns. I also added a check in TestType that ensures that ids are assigned correctly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---