orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request: ORC-8. Reimplement file-metadata to use the read...
Date Tue, 19 Jan 2016 18:53:42 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/15#discussion_r50155968
  
    --- Diff: tools/src/FileMetadata.cc ---
    @@ -16,168 +16,162 @@
      * limitations under the License.
      */
     
    +#include <getopt.h>
     #include <iostream>
     #include <fstream>
     #include <vector>
     #include <string>
     #include <sstream>
    -#include <iomanip>
     
    -#include "wrap/orc-proto-wrapper.hh"
     #include "orc/OrcFile.hh"
     
    -using namespace orc::proto;
    -
    -uint64_t getTotalPaddingSize(const Footer& footer) {
    -  uint64_t paddedBytes = 0;
    -  StripeInformation stripe;
    -  for (int stripeIx=1; stripeIx<footer.stripes_size(); stripeIx++) {
    -      stripe = footer.stripes(stripeIx-1);
    -      uint64_t prevStripeOffset = stripe.offset();
    -      uint64_t prevStripeLen = stripe.datalength() + stripe.indexlength() +
    -        stripe.footerlength();
    -      paddedBytes += footer.stripes(stripeIx).offset() -
    -        (prevStripeOffset + prevStripeLen);
    -  };
    -  return paddedBytes;
    +void printStripeInformation(std::ostream& out,
    +                            uint64_t index,
    +                            uint64_t columns,
    +                            std::unique_ptr<orc::StripeInformation> stripe,
    +                            bool verbose) {
    +  out << "    { \"stripe\": " << index
    +      << ", \"rows\": " << stripe->getNumberOfRows() << ",\n";
    +  out << "      \"offset\": " << stripe->getOffset()
    +      << ", \"length\": " << stripe->getLength() << ",\n";
    --- End diff --
    
    The lines get really long and hard to read. I don't think we should merge those lines.
I've grouped related fields together on to the same line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message