orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request: ORC-29. Enable ColumnPrinter to print only selec...
Date Wed, 06 Jan 2016 18:38:41 GMT
Github user omalley commented on the pull request:

    https://github.com/apache/orc/pull/9#issuecomment-169414339
  
    Ok, I pulled out the tree climbing code into TypeImpl::ensureIdAssigned(). I updated the
comments on the ReaderOptions::include methods to clarify that calling either one resets the
currently selected columns. I also added a check in TestType that ensures that ids are assigned
correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message