From issues-return-41658-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Thu Nov 28 18:12:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 295F618064C for ; Thu, 28 Nov 2019 19:12:38 +0100 (CET) Received: (qmail 23898 invoked by uid 500); 28 Nov 2019 18:12:37 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 23889 invoked by uid 99); 28 Nov 2019 18:12:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Nov 2019 18:12:37 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk-runtime-dotnet] kamyker commented on issue #26: Raw requests to skip JObject conversion Message-ID: <157496475743.14415.15810856822964296838.gitbox@gitbox.apache.org> Date: Thu, 28 Nov 2019 18:12:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kamyker commented on issue #26: Raw requests to skip JObject conversion URL: https://github.com/apache/openwhisk-runtime-dotnet/issues/26#issuecomment-559576862 Not sure how exactly AWS (from what I read they expose Stream to their [APIGatewayProxyRequest.cs](https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.APIGatewayEvents/APIGatewayProxyRequest.cs)) Tried Azure and they expose full HttpRequest ([docs](https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-http-webhook?tabs=csharp)) . I dislike automatic object conversion as it will use predefined serializer and instead prefer having raw data and do custom (and faster) deserialization. Using other providers that does it I also found it annoying and confusing when any exceptions happen outside my code and sometimes was unable to debug without me deploying whole local runtime solution. > I don't think we would want the full raw request stream going to the client. Exactly what I'd like as it's simplest and fastest(?) solution. Raw body of the request stream. How important are these lines? https://github.com/apache/openwhisk-runtime-dotnet/blob/c73dae10ab7538e5b3110158427f8ae5e6fbd399/core/dotnet2.2/proxy/Apache.OpenWhisk.Runtime.Common/Run.cs#L50-L76 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services