From issues-return-41591-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Mon Nov 25 19:44:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0A885180607 for ; Mon, 25 Nov 2019 20:44:39 +0100 (CET) Received: (qmail 16269 invoked by uid 500); 25 Nov 2019 19:44:39 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 16252 invoked by uid 99); 25 Nov 2019 19:44:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Nov 2019 19:44:39 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] rabbah commented on a change in pull request #4754: Mcdan/truncate keep running Message-ID: <157471107931.29178.13301459963475338734.gitbox@gitbox.apache.org> Date: Mon, 25 Nov 2019 19:44:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rabbah commented on a change in pull request #4754: Mcdan/truncate keep running URL: https://github.com/apache/openwhisk/pull/4754#discussion_r350385556 ########## File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala ########## @@ -62,40 +63,47 @@ protected[core] object ActivationResponse extends DefaultJsonProtocol { val ApplicationError = 1 // action ran but there was an error and it was handled val DeveloperError = 2 // action ran but failed to handle an error, or action did not run and failed to initialize val WhiskError = 3 // internal system error + val Truncated = 4 // action ran correctly, but returned a response that was too large Review comment: That's true and a good point. How are you anticipating making a distinction between large input that should persisted and one that shouldn't? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services