From issues-return-41049-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Wed Nov 6 05:03:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EEFC1180648 for ; Wed, 6 Nov 2019 06:03:44 +0100 (CET) Received: (qmail 37781 invoked by uid 500); 6 Nov 2019 05:03:44 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 37763 invoked by uid 99); 6 Nov 2019 05:03:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2019 05:03:44 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] chetanmeh commented on a change in pull request #4668: Allow namespace ignore in user-events Message-ID: <157301662418.13167.8326829038307945256.gitbox@gitbox.apache.org> Date: Wed, 06 Nov 2019 05:03:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit chetanmeh commented on a change in pull request #4668: Allow namespace ignore in user-events URL: https://github.com/apache/openwhisk/pull/4668#discussion_r342917723 ########## File path: core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/OpenWhiskEvents.scala ########## @@ -33,7 +33,7 @@ import scala.concurrent.{ExecutionContext, Future} object OpenWhiskEvents extends SLF4JLogging { - case class MetricConfig(port: Int, enableKamon: Boolean) + case class MetricConfig(port: Int, enableKamon: Boolean, ignoredNamespaces: List[String]) Review comment: Better to make it a `Set` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services