openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] rabbah commented on a change in pull request #4756: Create AES128 and AES256 encryption for parameters
Date Fri, 29 Nov 2019 14:01:33 GMT
rabbah commented on a change in pull request #4756: Create AES128 and AES256 encryption for
parameters
URL: https://github.com/apache/openwhisk/pull/4756#discussion_r352144325
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Parameter.scala
 ##########
 @@ -157,14 +174,19 @@ protected[entity] class ParameterName protected[entity] (val name:
String) exten
  * @param v the value of the parameter, may be null
  * @param init if true, this parameter value is only offered to the action during initialization
  */
-protected[entity] case class ParameterValue protected[entity] (private val v: JsValue, val
init: Boolean) {
+protected[entity] case class ParameterValue protected[entity] (private val v: JsValue,
+                                                               val init: Boolean,
+                                                               val e: JsValue = JsNull) {
 
 Review comment:
   Why not just store the encrypted value and a boolean to indicate it's encrypted?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message