openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] ruediger-maass opened a new pull request #4715: Moremetricoptions
Date Thu, 07 Nov 2019 11:39:37 GMT
ruediger-maass opened a new pull request #4715: Moremetricoptions
URL: https://github.com/apache/openwhisk/pull/4715
 
 
   Extension points for kamon metric key generator and reporter
   
   ## Description
   We need a different metric key generator and a different reporter in our product. Therefore
we request two simple extension points in the `application.conf` for `common` that can be
easily configured with two environment variables. If these two variables are not defined then
Openwhisk does not change the current behavior.
   
   This PR also includes changes for exposing the two new environment variables to the deployment.
Since this is a special use case and you would normally have to add code for a different generator
and reporter it is the question if this PR should be limited to only include the changes for
`application.conf`.
   
   ## My changes affect the following components
   Current behavior of OpenWhisk only changes if the aforementioned variables are actively
used.
   - [ ] API
   - [x] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [x] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [x] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message