openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] selfxp commented on a change in pull request #4668: Allow namespace ignore in user-events
Date Wed, 06 Nov 2019 00:40:28 GMT
selfxp commented on a change in pull request #4668: Allow namespace ignore in user-events
URL: https://github.com/apache/openwhisk/pull/4668#discussion_r342868680
 
 

 ##########
 File path: core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/EventConsumer.scala
 ##########
 @@ -94,6 +95,9 @@ case class EventConsumer(settings: ConsumerSettings[String, String], recorders:
   private def processEvent(value: String): Unit = {
     EventMessage
       .parse(value)
+      .filter { e =>
+        !metricConfig.ignoredNamespaces.contains(e.namespace)
+      }
 
 Review comment:
   Makes sense @chetanmeh. Added a new metric for total namespace activations in both `PrometheusRecorder`
and `KamonRecorder`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message