openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] markusthoemmes commented on a change in pull request #4709: Extend the SPI entitlement interface
Date Tue, 05 Nov 2019 11:01:14 GMT
markusthoemmes commented on a change in pull request #4709: Extend the SPI entitlement interface
URL: https://github.com/apache/openwhisk/pull/4709#discussion_r342500722
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala
 ##########
 @@ -264,6 +264,21 @@ protected[core] abstract class EntitlementProvider(
           transid)))
   }
 
+  /**
+   * Constructs a RejectRequest containing the resources for which access authorization check
failed..
+   *
+   * @param resources resources for which access authorization check failed
+   * @return a RejectRequest with the appropriate message
+   */
+  private def checkAuthorizationFailureOn(resources: Set[Resource])(implicit transid: TransactionId)
= {
+    RejectRequest(
+      InternalServerError,
+      Some(
+        ErrorResponse(
+          Messages.failedToCheckAccessResourceAuthorization(resources.map(_.fqname).toSeq.sorted.toSet.mkString(",
")),
 
 Review comment:
   The `toSet` shouldn't be necessary and in fact screw the sorted behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message