openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] chetanmeh commented on a change in pull request #4712: Fixes #4711 - add a namespace configuration option to KCF
Date Mon, 04 Nov 2019 19:17:28 GMT
chetanmeh commented on a change in pull request #4712: Fixes #4711 - add a namespace configuration
option to KCF
URL: https://github.com/apache/openwhisk/pull/4712#discussion_r342223399
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala
 ##########
 @@ -76,6 +76,7 @@ case class KubernetesClientConfig(timeouts: KubernetesClientTimeoutConfig,
                                   invokerAgent: KubernetesInvokerAgentConfig,
                                   userPodNodeAffinity: KubernetesInvokerNodeAffinity,
                                   portForwardingEnabled: Boolean,
+                                  actionNamespace: Option[String] = None,
 
 Review comment:
   Would be helpful to have a comment in application.conf explaining this optional config
   
   https://github.com/apache/openwhisk/blob/f3040925aa408a0b32dd4f542c815a638a797cc4/core/invoker/src/main/resources/application.conf#L65-L67

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message