From issues-return-40944-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Tue Oct 29 05:25:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5A78F1804BB for ; Tue, 29 Oct 2019 06:25:46 +0100 (CET) Received: (qmail 73850 invoked by uid 500); 29 Oct 2019 05:25:45 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 73841 invoked by uid 99); 29 Oct 2019 05:25:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2019 05:25:45 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] codecov-io commented on issue #4699: Optimize ack messages for setups not collecting logs Message-ID: <157232674558.14354.2709220257387271137.gitbox@gitbox.apache.org> Date: Tue, 29 Oct 2019 05:25:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io commented on issue #4699: Optimize ack messages for setups not collecting logs URL: https://github.com/apache/openwhisk/pull/4699#issuecomment-547261965 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=h1) Report > Merging [#4699](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/f69ecb78eafde2cc8f55ba38570f9bab92cc077a?src=pr&el=desc) will **decrease** coverage by `6.44%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/openwhisk/pull/4699/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4699 +/- ## ========================================== - Coverage 84.8% 78.35% -6.45% ========================================== Files 196 198 +2 Lines 8803 8812 +9 Branches 603 598 -5 ========================================== - Hits 7465 6905 -560 - Misses 1338 1907 +569 ``` | [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...che/openwhisk/core/invoker/LogStoreCollector.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9Mb2dTdG9yZUNvbGxlY3Rvci5zY2FsYQ==) | `100% <100%> (ø)` | | | [.../openwhisk/core/containerpool/ContainerProxy.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQcm94eS5zY2FsYQ==) | `92.96% <100%> (+0.07%)` | :arrow_up: | | [...penwhisk/core/containerpool/logging/LogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0xvZ1N0b3JlLnNjYWxh) | `100% <100%> (ø)` | | | [...core/containerpool/logging/LogDriverLogStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9sb2dnaW5nL0xvZ0RyaXZlckxvZ1N0b3JlLnNjYWxh) | `40% <100%> (+15%)` | :arrow_up: | | [...pache/openwhisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `80.7% <100%> (+1.23%)` | :arrow_up: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...enwhisk/connector/kafka/KamonMetricsReporter.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYW1vbk1ldHJpY3NSZXBvcnRlci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: | | [...e/database/cosmosdb/cache/ChangeFeedConsumer.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NoYW5nZUZlZWRDb25zdW1lci5zY2FsYQ==) | `0% <0%> (-100%)` | :arrow_down: | | [...ore/database/cosmosdb/cache/CacheInvalidator.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29yZS9jb3Ntb3NkYi9jYWNoZS1pbnZhbGlkYXRvci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL29wZW53aGlzay9jb3JlL2RhdGFiYXNlL2Nvc21vc2RiL2NhY2hlL0NhY2hlSW52YWxpZGF0b3Iuc2NhbGE=) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.85%)` | :arrow_down: | | ... and [17 more](https://codecov.io/gh/apache/openwhisk/pull/4699/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=footer). Last update [f69ecb7...be1a5d8](https://codecov.io/gh/apache/openwhisk/pull/4699?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services