From issues-return-40768-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Sat Oct 19 07:02:41 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7C0F2180654 for ; Sat, 19 Oct 2019 09:02:41 +0200 (CEST) Received: (qmail 4277 invoked by uid 500); 19 Oct 2019 07:02:41 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 4268 invoked by uid 99); 19 Oct 2019 07:02:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Oct 2019 07:02:40 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] selfxp commented on a change in pull request #4693: Updates Alpakka Kafka to 1.1.0 Message-ID: <157146856083.3659.2964209612076182911.gitbox@gitbox.apache.org> Date: Sat, 19 Oct 2019 07:02:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit selfxp commented on a change in pull request #4693: Updates Alpakka Kafka to 1.1.0 URL: https://github.com/apache/openwhisk/pull/4693#discussion_r336725290 ########## File path: core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/PrometheusRecorder.scala ########## @@ -208,12 +209,7 @@ object PrometheusRecorder extends PrometheusMetricNames { initiatorNamespace, actionName) private val memoryGauge = - histogram( - memoryMetric, - "Memory consumption of the action containers", - actionNamespace, - initiatorNamespace, - actionName) + gauge(memoryMetric, "Memory consumption of the action containers", actionNamespace, initiatorNamespace, actionName) Review comment: I think this requires a change in this [line](https://github.com/apache/openwhisk/blob/master/core/monitoring/user-events/compose/grafana/dashboards/openwhisk_events.json#L719) from: ``` "expr": "sum(increase(openwhisk_action_memory_sum{region=~\"$region\",stack=~\"$stack\",namespace=~\"$namespace\",action=~\"$action\",initiator=~\"$initiator\"}[$__range])) by (action) / sum(increase(openwhisk_action_memory_count{region=~\"$region\",stack=~\"$stack\",namespace=~\"$namespace\",action=~\"$action\"}[$__range])) by (action) > 0", ``` to ``` "expr": "openwhisk_action_memory{region=~"$region",stack=~"$stack",namespace=~"$namespace",action=~"$action",initiator=~"$initiator"}", ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services