openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] selfxp commented on a change in pull request #4693: Updates Alpakka Kafka to 1.1.0
Date Sat, 19 Oct 2019 07:01:42 GMT
selfxp commented on a change in pull request #4693: Updates Alpakka Kafka to 1.1.0
URL: https://github.com/apache/openwhisk/pull/4693#discussion_r336725290
 
 

 ##########
 File path: core/monitoring/user-events/src/main/scala/org/apache/openwhisk/core/monitoring/metrics/PrometheusRecorder.scala
 ##########
 @@ -208,12 +209,7 @@ object PrometheusRecorder extends PrometheusMetricNames {
       initiatorNamespace,
       actionName)
   private val memoryGauge =
-    histogram(
-      memoryMetric,
-      "Memory consumption of the action containers",
-      actionNamespace,
-      initiatorNamespace,
-      actionName)
+    gauge(memoryMetric, "Memory consumption of the action containers", actionNamespace, initiatorNamespace,
actionName)
 
 Review comment:
   I think this requires a change in this [line](https://github.com/apache/openwhisk/blob/master/core/monitoring/user-events/compose/grafana/dashboards/openwhisk_events.json#L719)
from:
   ```
   "expr": "sum(increase(openwhisk_action_memory_sum{region=~\"$region\",stack=~\"$stack\",namespace=~\"$namespace\",action=~\"$action\",initiator=~\"$initiator\"}[$__range]))
by (action) / sum(increase(openwhisk_action_memory_count{region=~\"$region\",stack=~\"$stack\",namespace=~\"$namespace\",action=~\"$action\"}[$__range]))
by (action) > 0",
   ```
   to
   ```
   "expr": "openwhisk_action_memory{region=~"$region",stack=~"$stack",namespace=~"$namespace",action=~"$action",initiator=~"$initiator"}"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message