openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] mhenke1 commented on a change in pull request #4647: Remove deadcode from test helpers.
Date Tue, 08 Oct 2019 11:40:10 GMT
mhenke1 commented on a change in pull request #4647: Remove deadcode from test helpers.
URL: https://github.com/apache/openwhisk/pull/4647#discussion_r330095392
 
 

 ##########
 File path: tests/src/test/scala/common/TestUtils.java
 ##########
 @@ -112,57 +111,6 @@ public static String getTestApiGwFilename(String name) {
         return new File(testApiGwDir, name).toString();
     }
 
-    /**
-     * Gets the value of VCAP_SERVICES.
-     *
-     * @return VCAP_SERVICES as a JSON object
-     */
-    public static JsonObject getVCAPServices() {
 
 Review comment:
   @rabbah 
   Unfortunately there are tests specific to IBM Functions using `getVCAPServices` (and with
it `vcapFile`).
   Leaving these two things in for now would give our team time to adapt changes without direct
pressure.
   
   `getVCAPcredentials`, `getCredentials` and `DEFAULT_CONCURRENCY` are not used.
   If there is agreement I would like ask to remove the later ones only and get to the used
ones in a later PR.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message