openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] rabbah commented on a change in pull request #4659: add config to allow removal of Activation result before storing in some cases
Date Tue, 01 Oct 2019 23:28:53 GMT
rabbah commented on a change in pull request #4659: add config to allow removal of Activation
result before storing in some cases
URL: https://github.com/apache/openwhisk/pull/4659#discussion_r330317908
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala
 ##########
 @@ -553,7 +553,14 @@ trait WhiskWebActionsApi
                                              httpEntity: HttpEntity)(implicit transid: TransactionId)
= {
 
     def process(body: Option[JsValue], isRawHttpAction: Boolean) = {
-      processRequest(actionOwnerIdentity, action, extension, onBehalfOf, context.withBody(body),
isRawHttpAction)
+      processRequest(
+        actionOwnerIdentity,
+        action,
+        extension,
+        onBehalfOf,
+        context.withBody(body),
+        isRawHttpAction,
+        context.queryAsMap.contains("debug"))
 
 Review comment:
   this captures `debug` as a "system" query parameter and should be documented.. alternatively,
why not use a `X-` header (similar to the one for extra system tracing)?
   
   (actions may still use the `debug` query parameter from what I see but this could have
unintended consequences.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message