From issues-return-40091-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Mon Sep 23 01:35:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7A3F118065B for ; Mon, 23 Sep 2019 03:35:31 +0200 (CEST) Received: (qmail 15624 invoked by uid 500); 23 Sep 2019 01:35:30 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 15615 invoked by uid 99); 23 Sep 2019 01:35:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Sep 2019 01:35:30 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] jiangpengcheng commented on a change in pull request #4609: Add namespace field to activation log Message-ID: <156920253080.2198.18017336495111674549.gitbox@gitbox.apache.org> Date: Mon, 23 Sep 2019 01:35:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jiangpengcheng commented on a change in pull request #4609: Add namespace field to activation log URL: https://github.com/apache/openwhisk/pull/4609#discussion_r326931362 ########## File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala ########## @@ -84,9 +84,11 @@ class ActivationFileStorage(logFilePrefix: String, private def transcribeLogs(activation: WhiskActivation, additionalFields: Map[String, JsValue]) = activation.logs.logs.map { log => - val line = JsObject( - Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++ Map( - "activationId" -> activation.activationId.toJson) ++ additionalFields) + val line = + JsObject( + Map("type" -> "user_log".toJson) ++ Map("message" -> log.toJson) ++ Map( + "activationId" -> activation.activationId.toJson) ++ Map( + "namespace" -> activation.namespace.asString.toJson) ++ additionalFields) Review comment: but then activation will also has an extra "namespace" field, is that ok? https://github.com/apache/openwhisk/blob/400a7915115576a363858788a6d080c389a80317/common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala#L116 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services