From issues-return-40019-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Thu Sep 19 14:24:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0C10918062C for ; Thu, 19 Sep 2019 16:24:25 +0200 (CEST) Received: (qmail 35675 invoked by uid 500); 19 Sep 2019 14:24:25 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 35656 invoked by uid 99); 19 Sep 2019 14:24:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Sep 2019 14:24:25 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. Message-ID: <156890306544.25940.8973136964864667154.gitbox@gitbox.apache.org> Date: Thu, 19 Sep 2019 14:24:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available. URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326201849 ########## File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala ########## @@ -54,9 +54,10 @@ object InvokerReactive extends InvokerProvider { * @param Boolean is true iff the activation was a blocking request * @param ControllerInstanceId the originating controller/loadbalancer id * @param UUID is the UUID for the namespace owning the activation - * @param Boolean is true this is resource free message and false if this is a result forwarding message + * @param AcknowledegmentMessage the acknowledgement message to send */ - type ActiveAck = (TransactionId, WhiskActivation, Boolean, ControllerInstanceId, UUID, Boolean) => Future[Any] + type ActiveAck = Review comment: This ends up being a bit more extensive than at first appearances so we should defer it to a subsequent patch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services