From issues-return-39870-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Mon Sep 16 02:36:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A30AE180648 for ; Mon, 16 Sep 2019 04:36:26 +0200 (CEST) Received: (qmail 27920 invoked by uid 500); 16 Sep 2019 02:36:26 -0000 Mailing-List: contact issues-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list issues@openwhisk.apache.org Received: (qmail 27888 invoked by uid 99); 16 Sep 2019 02:36:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2019 02:36:25 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [openwhisk] BillZong commented on a change in pull request #4619: Add ansible deploy options Message-ID: <156860138578.14940.9209290105471340158.gitbox@gitbox.apache.org> Date: Mon, 16 Sep 2019 02:36:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit BillZong commented on a change in pull request #4619: Add ansible deploy options URL: https://github.com/apache/openwhisk/pull/4619#discussion_r324497543 ########## File path: ansible/roles/zookeeper/tasks/deploy.yml ########## @@ -17,13 +17,6 @@ --- # This role will install Kafka with Zookeeper in group 'kafka' in the environment inventory -- name: "pull the zookeeper:{{ zookeeper.version }} image" Review comment: The retry here is meaningless, since errors happened here are fatal for deployment. e.g. image name/tag spelled wrong, wrong password for docker repo, network timeout, etc. All we should do is to fix them and re-deploy, instead of retrying. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services