openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] sven-lange-last commented on issue #4641: Revert erroneous change which drops user events on some completions.
Date Tue, 24 Sep 2019 13:10:51 GMT
sven-lange-last commented on issue #4641: Revert erroneous change which drops user events on
some completions.
URL: https://github.com/apache/openwhisk/pull/4641#issuecomment-534551167
 
 
   I ran following `UserEventTests` in our build / test pipeline:
   
   https://github.com/apache/openwhisk/blob/master/tests/src/test/scala/org/apache/openwhisk/common/UserEventTests.scala
   
   The test failed once (PG 1 / 25) because it only waits for the user event message to arrive
on Kafka for 10 seconds. So from my perspective, we should increase the maximum wait time
to make the test a little more robust. A longer max poll time should not harm in most cases
because the `consumer.peek()` will return as soon as messages could be received.
   
   The next test run of `UserEventTests` (PG 1 / 26) succeeded with this PR. It always fails
with current master.
   
   In other words: this PR fixes the missing user events.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message