openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] rabbah commented on a change in pull request #4644: Retry NoHttpResponseException for standalone mode in ApacheContainerClient
Date Tue, 24 Sep 2019 12:19:37 GMT
rabbah commented on a change in pull request #4644: Retry NoHttpResponseException for standalone
mode in ApacheContainerClient
URL: https://github.com/apache/openwhisk/pull/4644#discussion_r327580674
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -449,6 +449,15 @@ whisk {
         # for details
         require-api-key-annotation = true
     }
+
+    apache-client {
+        # By default Apache HTTP Client would not retry NoHttpResponseException cases
+        # as its not sure that server has processed the request or not
+        # At times this issue is seen in local setups where with retry the request flow
+        # work as expected. So for such cases like when running in Standalone mode this
+        # setting can be enabled
 
 Review comment:
   I would perhaps highlight/stress that this setting should generally be `false` unless you
know what you're doing. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message