openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] rabbah commented on a change in pull request #4624: Combines active ack and slot release when both are available.
Date Thu, 19 Sep 2019 14:24:25 GMT
rabbah commented on a change in pull request #4624: Combines active ack and slot release when
both are available.
URL: https://github.com/apache/openwhisk/pull/4624#discussion_r326201849
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/InvokerReactive.scala
 ##########
 @@ -54,9 +54,10 @@ object InvokerReactive extends InvokerProvider {
    * @param Boolean is true iff the activation was a blocking request
    * @param ControllerInstanceId the originating controller/loadbalancer id
    * @param UUID is the UUID for the namespace owning the activation
-   * @param Boolean is true this is resource free message and false if this is a result forwarding
message
+   * @param AcknowledegmentMessage the acknowledgement message to send
    */
-  type ActiveAck = (TransactionId, WhiskActivation, Boolean, ControllerInstanceId, UUID,
Boolean) => Future[Any]
+  type ActiveAck =
 
 Review comment:
   This ends up being a bit more extensive than at first appearances so we should defer it
to a subsequent patch. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message