openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] BillZong commented on a change in pull request #4619: Add ansible deploy options
Date Mon, 16 Sep 2019 02:36:25 GMT
BillZong commented on a change in pull request #4619: Add ansible deploy options
URL: https://github.com/apache/openwhisk/pull/4619#discussion_r324497543
 
 

 ##########
 File path: ansible/roles/zookeeper/tasks/deploy.yml
 ##########
 @@ -17,13 +17,6 @@
 ---
 # This role will install Kafka with Zookeeper in group 'kafka' in the environment inventory
 
-- name: "pull the zookeeper:{{ zookeeper.version }} image"
 
 Review comment:
   The retry here is meaningless, since errors happened here are fatal for deployment.
   e.g. image name/tag spelled wrong, wrong password for docker repo, network timeout, etc.
   
   All we should do is to fix them and re-deploy, instead of retrying.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message