openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] tysonnorris commented on a change in pull request #4625: emit additional metrics about invoker ContainerPool
Date Fri, 13 Sep 2019 18:48:14 GMT
tysonnorris commented on a change in pull request #4625: emit additional metrics about invoker
ContainerPool
URL: https://github.com/apache/openwhisk/pull/4625#discussion_r324322786
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -187,6 +192,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
                   s"userNamespace: ${r.msg.user.namespace.name}, action: ${r.action}, " +
                   s"needed memory: ${r.action.limits.memory.megabytes} MB, " +
                   s"waiting messages: ${runBuffer.size}")(r.msg.transid)
+              MetricEmitter.emitCounterMetric(LoggingMarkers.CONTAINER_POOL_RESCHEDULED_ACTIVATION)
 
 Review comment:
   Note that this will currently only emit once-per-log-timeout - so it will not be accurate;
once #4593 is merged, this metric should be counted every message loop (since message processing
should no longer be in a "tight" loop). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message