openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] rabbah commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory
Date Thu, 29 Aug 2019 18:16:55 GMT
rabbah commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory
URL: https://github.com/apache/openwhisk/pull/4595#discussion_r319206866
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala
 ##########
 @@ -89,6 +89,17 @@ trait ContainerFactory {
    * - It is desired that the container supports and enforces the specified memory limit
and CPU shares.
    *   In particular, action memory limits rely on the underlying container technology.
    */
+  def createContainer(
 
 Review comment:
   Is that better than proliferating signatures? Does it affect any SPI signatures?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message