openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] ruediger-maass commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log
Date Thu, 29 Aug 2019 13:49:49 GMT
ruediger-maass commented on a change in pull request #4596: Allow individual field sets for
activation_record and user_log
URL: https://github.com/apache/openwhisk/pull/4596#discussion_r319080973
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala
 ##########
 @@ -111,8 +111,16 @@ class ActivationFileStorage(logFilePrefix: String,
   def activationToFile(activation: WhiskActivation,
                        context: UserContext,
                        additionalFields: Map[String, JsValue] = Map.empty) = {
-    val transcribedLogs = transcribeLogs(activation, additionalFields)
-    val transcribedActivation = transcribeActivation(activation, additionalFields)
+    activationToFileExtended(activation, context, additionalFields, additionalFields)
+  }
+
+  // used by external ArtifactActivationStore SPI implementation
+  def activationToFileExtended(activation: WhiskActivation,
+                               context: UserContext,
+                               additionalFieldsForLogs: Map[String, JsValue] = Map.empty,
+                               additionalFieldsForActivation: Map[String, JsValue] = Map.empty)
= {
+    val transcribedLogs = transcribeLogs(activation, additionalFieldsForLogs)
 
 Review comment:
   ok, done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message