openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [openwhisk] sven-lange-last commented on issue #4582: Action container log collection does not wait for sentinel on developer error
Date Thu, 15 Aug 2019 08:28:46 GMT
sven-lange-last commented on issue #4582: Action container log collection does not wait for
sentinel on developer error
URL: https://github.com/apache/openwhisk/pull/4582#issuecomment-521560275
 
 
   @markusthoemmes @rabbah I think I addressed your review comments. Please check and let
me know.
   
   @rabbah concerning your comment / request:
   
   > I think this is a dilation factor we can move to the configuration parameters.
   
   I didn't fully expose this factor as a configuration parameter yet because we were fine
so far with also having other timeouts as `val`s local to the class. See https://github.com/apache/openwhisk/blob/b5b88ece0ae08c87948796b38ab18e55ab4b70a7/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerContainer.scala#L176-L178
   
   * That's why I renamed one of the timeouts for more clarity and added `logCollectingTimeoutPerMBLogLimit`
to this list.
   * I suggest that we should expose all or none of these config parameters and only if there
is a need to change these defaults. @rabbah okay to delay loading these config parameters
or do you need config loading already now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message