openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk] markusthoemmes commented on a change in pull request #4561: Add more diagnostic information to completion ack processing
Date Mon, 22 Jul 2019 07:34:33 GMT
markusthoemmes commented on a change in pull request #4561: Add more diagnostic information
to completion ack processing
URL: https://github.com/apache/incubator-openwhisk/pull/4561#discussion_r305706944
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/common/Logging.scala
 ##########
 @@ -414,6 +414,28 @@ object LoggingMarkers {
       LogMarkerToken(loadbalancer + controllerInstance.asString, s"memory${actionType}Inflight",
counter)(
         MeasurementUnit.none)
 
+  // Counter metrics for completion acks in load balancer
+  sealed trait completionAckType { def asString: String = ??? }
+  case object regularCompletionAck extends completionAckType { override def asString = "regular"
}
+  case object forcedCompletionAck extends completionAckType { override def asString = "forced"
}
+  case object healthcheckCompletionAck extends completionAckType { override def asString
= "healthcheck" }
+  case object regularAfterForcedCompletionAck extends completionAckType { override def asString
= "regularAfterForced" }
+  case object forcedAfterRegularCompletionAck extends completionAckType { override def asString
= "forcedAfterRegular" }
 
 Review comment:
   @style95 for posterity: We use `asString` throughout the codebase for places where we explicitly
want a conversion to string to happen. `toString` way too often bites you so we make these
conversions as explicit as possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message