From issues-return-37822-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Tue Jun 18 11:32:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2935118066B for ; Tue, 18 Jun 2019 13:32:36 +0200 (CEST) Received: (qmail 39507 invoked by uid 500); 18 Jun 2019 11:32:35 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 39498 invoked by uid 99); 18 Jun 2019 11:32:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2019 11:32:35 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [incubator-openwhisk] mhenke1 commented on issue #4514: Fix js syntax error which made tests fail with the latest nodejs runtime Message-ID: <156085755049.17792.1049462090058870057.gitbox@gitbox.apache.org> Date: Tue, 18 Jun 2019 11:32:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mhenke1 commented on issue #4514: Fix js syntax error which made tests fail with the latest nodejs runtime URL: https://github.com/apache/incubator-openwhisk/pull/4514#issuecomment-503064973 @rabbah Though I am wondering that the existing code did run at all without the `var`or `let` keyword before a declaring a variable, the adaption needed shows that also customer code might brake with the adapted nodejs runtime. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services