From issues-return-37738-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Wed Jun 12 16:09:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6FC8018061A for ; Wed, 12 Jun 2019 18:09:51 +0200 (CEST) Received: (qmail 99137 invoked by uid 500); 12 Jun 2019 16:09:50 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 99128 invoked by uid 99); 12 Jun 2019 16:09:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jun 2019 16:09:50 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [incubator-openwhisk-runtime-nodejs] rabbah opened a new pull request #133: Refactoring of the service and runner, no semantic changes intended. Message-ID: <156035579084.1754.12694957452707285282.gitbox@gitbox.apache.org> Date: Wed, 12 Jun 2019 16:09:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rabbah opened a new pull request #133: Refactoring of the service and runner, no semantic changes intended. URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/133 This PR applies refactoring and JS-isms, and intends no semantic changes. It is best to review each of the commits on its own as I grouped them logically into their change sets. Ignoring white space is also advised. Note while some `lets` may be constants, the use of `let` is sometimes preferred to keep the scope of the variable scoped to its nearest `{}`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services