openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk] chetanmeh commented on a change in pull request #4504: Remove default port on api host.
Date Tue, 04 Jun 2019 15:12:53 GMT
chetanmeh commented on a change in pull request #4504: Remove default port on api host.
URL: https://github.com/apache/incubator-openwhisk/pull/4504#discussion_r290350138
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/WhiskConfig.scala
 ##########
 @@ -54,8 +54,12 @@ class WhiskConfig(requiredProperties: Map[String, String],
   val dockerEndpoint = this(WhiskConfig.dockerEndpoint)
   val dockerPort = this(WhiskConfig.dockerPort)
 
-  val wskApiHost = this(WhiskConfig.wskApiProtocol) + "://" + this(WhiskConfig.wskApiHostname)
+ ":" + this(
-    WhiskConfig.wskApiPort)
+  val wskApiHost: String = scala.util
+    .Try(
+      akka.http.scaladsl.model.Uri.normalize(
 
 Review comment:
   Nit. Better to import the package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message