openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk-deploy-kube] kpavel commented on a change in pull request #463: Provide support for Lean OpenWhisk configuration
Date Tue, 21 May 2019 10:10:25 GMT
kpavel commented on a change in pull request #463: Provide support for Lean OpenWhisk  configuration
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/463#discussion_r285950556
 
 

 ##########
 File path: helm/openwhisk/templates/invoker-agent-pod.yaml
 ##########
 @@ -1,7 +1,7 @@
 # Licensed to the Apache Software Foundation (ASF) under one or more contributor
 # license agreements; and to You under the Apache License, Version 2.0.
 
-{{ if .Values.invoker.containerFactory.kubernetes.agent.enabled }}
+{{ if (.Values.invoker.containerFactory.kubernetes.agent.enabled) and not .Values.controller.lean
}}
 
 Review comment:
   I removed it as it's not mandatory, but in case user specifies in lean mode:
   ```invoker:
     containerFactory:
       kubernetes:
         agent:
           enabled: true
   ```
   it will spawn unnecessary invoker-agent pods

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message