From issues-return-36652-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Tue Apr 16 15:30:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99CFA180630 for ; Tue, 16 Apr 2019 17:30:10 +0200 (CEST) Received: (qmail 76309 invoked by uid 500); 16 Apr 2019 15:30:09 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 76300 invoked by uid 99); 16 Apr 2019 15:30:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2019 15:30:09 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [incubator-openwhisk-runtime-nodejs] pritidesai commented on a change in pull request #119: An ability to run on Knative along with OpenWhisk Message-ID: <155542860462.16375.3652975880622950340.gitbox@gitbox.apache.org> Date: Tue, 16 Apr 2019 15:30:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pritidesai commented on a change in pull request #119: An ability to run on Knative along with OpenWhisk URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r275859247 ########## File path: core/nodejsActionBase/src/service.js ########## @@ -52,17 +57,27 @@ function NodeActionService(config) { return responseMessage(code, { error: errorMsg }); } + /** Review comment: dropped it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services