From issues-return-36218-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Wed Apr 3 00:29:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2060A180672 for ; Wed, 3 Apr 2019 02:29:35 +0200 (CEST) Received: (qmail 74858 invoked by uid 500); 3 Apr 2019 00:29:35 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 74829 invoked by uid 99); 3 Apr 2019 00:29:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Apr 2019 00:29:35 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [incubator-openwhisk-utilities] mrutkows commented on a change in pull request #57: Fix exclusion directory and file matching and add support for reading a top level gitignore file Message-ID: <155425137459.23596.4378751270329002505.gitbox@gitbox.apache.org> Date: Wed, 03 Apr 2019 00:29:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mrutkows commented on a change in pull request #57: Fix exclusion directory and file matching and add support for reading a top level gitignore file URL: https://github.com/apache/incubator-openwhisk-utilities/pull/57#discussion_r271542424 ########## File path: scancode/scanCode.py ########## @@ -549,7 +554,7 @@ def is_dir(path): print_warning(WARN_SCAN_EXCLUDED_PATH % excluded_path) # Display which files where excluded from these paths - if args.display_exclusions: + if VERBOSE: Review comment: Sometimes the listing of exclusions is desirable unto itself (apart from VERBOSE); would prefer leaving this as a sep. option in addition to general verbose to prevent a deluge of VERBOSE output which would dwarf the more important viewing of file that are being scanned and errors found within them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services