openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk-runtime-nodejs] rabbah commented on a change in pull request #119: An ability to run on Knative along with OpenWhisk
Date Wed, 17 Apr 2019 20:36:44 GMT
rabbah commented on a change in pull request #119: An ability to run on Knative along with
OpenWhisk
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r276422118
 
 

 ##########
 File path: core/nodejsActionBase/src/service.js
 ##########
 @@ -15,16 +15,19 @@
  * limitations under the License.
  */
 
+
 var NodeActionRunner = require('../runner');
 
 function NodeActionService(config) {
+
     var Status = {
         ready: 'ready',
         starting: 'starting',
         running: 'running',
         stopped: 'stopped'
     };
 
+    // TODO: save the entire configuration for use by any of the route handlers
 
 Review comment:
   this todo i think is invalid.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message