openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk-runtime-nodejs] pritidesai commented on a change in pull request #119: An ability to run on Knative along with OpenWhisk
Date Tue, 16 Apr 2019 15:27:28 GMT
pritidesai commented on a change in pull request #119: An ability to run on Knative along with
OpenWhisk
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r275857857
 
 

 ##########
 File path: core/nodejsActionBase/src/service.js
 ##########
 @@ -155,10 +174,12 @@ function NodeActionService(config) {
 
     function doRun(req) {
         var msg = req && req.body || {};
+        // Move per-activation keys to process env. vars with __OW_ (reserved) prefix)
 
 Review comment:
   hey Rodric, I am not able to spot the imbalance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message