openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk-runtime-nodejs] rabbah commented on a change in pull request #119: An ability to run on Knative along with OpenWhisk
Date Mon, 15 Apr 2019 20:07:02 GMT
rabbah commented on a change in pull request #119: An ability to run on Knative along with
OpenWhisk
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119#discussion_r275522923
 
 

 ##########
 File path: core/nodejsActionBase/src/service.js
 ##########
 @@ -82,13 +99,15 @@ function NodeActionService(config) {
                     setStatus(Status.ready);
                     return responseMessage(200, { OK: true });
                 }).catch(function (error) {
-                    var errStr = error.stack ? String(error.stack) : error;
                     setStatus(Status.stopped);
-                    return Promise.reject(errorMessage(502, "Initialization has failed due
to: " + errStr));
+                    var errStr = "Initialization has failed due to: " + error.stack ? String(error.stack)
: error;
+                    return Promise.reject(errorMessage(502, errStr));
                 });
             } else {
                 setStatus(Status.ready);
-                return Promise.reject(errorMessage(403, "Missing main/no code to execute."));
+                var msg = "Missing main/no code to execute.";
+                console.error("Internal system error:", msg);
 
 Review comment:
   this error will now appear is user's action logs - which is new behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message