openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk] tysonnorris commented on a change in pull request #4437: S3AttachmentStore: prevent deletion of other s3 bucket keys on doc delete
Date Thu, 11 Apr 2019 16:19:41 GMT
tysonnorris commented on a change in pull request #4437: S3AttachmentStore: prevent deletion
of other s3 bucket keys on doc delete
URL: https://github.com/apache/incubator-openwhisk/pull/4437#discussion_r274507275
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/cosmosdb/CosmosDBArtifactStore.scala
 ##########
 @@ -78,7 +78,7 @@ class CosmosDBArtifactStore[DocumentAbstraction <: DocumentSerializer](protected
     this,
     s"Initializing CosmosDBArtifactStore for collection [$collName]. Service endpoint [${client.getServiceEndpoint}],
" +
       s"Read endpoint [${client.getReadEndpoint}], Write endpoint [${client.getWriteEndpoint}],
Connection Policy [${client.getConnectionPolicy}], " +
-      s"Time to live [${collection.getDefaultTimeToLive} secs, clusterId [${config.clusterId}],
soft delete TTL [${config.softDeleteTTL}]")
+      s"Time to live [${collection.getDefaultTimeToLive} secs, clusterId [${config.clusterId}],
soft delete TTL [${config.softDeleteTTL}], Consistency Level [${config.consistencyLevel}]")
 
 Review comment:
   yes it is here: https://github.com/apache/incubator-openwhisk/blob/e7253ac5bac519df289321a22c5ee923bb96c1f7/common/scala/src/main/resources/application.conf#L194

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message