openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk-package-kafka] mdeuser commented on a change in pull request #332: Prevent parsing floats as Infinity and -Infinity
Date Tue, 09 Apr 2019 16:38:02 GMT
mdeuser commented on a change in pull request #332: Prevent parsing floats as Infinity and
-Infinity
URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/332#discussion_r273581281
 
 

 ##########
 File path: provider/consumer.py
 ##########
 @@ -526,3 +526,14 @@ def __on_revoke(self, consumer, partitions):
 
     def __errorOnJSONConstant(self, data):
     	raise(ValueError('Invalid JSON detected.'))
 
 Review comment:
   how about providing a more detailed exception message similar to the ones from `__parseFloat`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message