From issues-return-36004-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Wed Mar 27 18:49:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8D73618075F for ; Wed, 27 Mar 2019 19:49:33 +0100 (CET) Received: (qmail 22960 invoked by uid 500); 27 Mar 2019 18:49:32 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 22951 invoked by uid 99); 27 Mar 2019 18:49:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Mar 2019 18:49:32 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [incubator-openwhisk-runtime-python] rabbah commented on a change in pull request #54: move global variables initialized to init Message-ID: <155371257212.3865.15398454687451963590.gitbox@gitbox.apache.org> Date: Wed, 27 Mar 2019 18:49:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rabbah commented on a change in pull request #54: move global variables initialized to init URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/54#discussion_r269717754 ########## File path: tests/src/test/scala/runtime/actionContainers/PythonActionContainerTests.scala ########## @@ -267,10 +267,7 @@ class PythonActionContainerTests extends BasicActionRunnerTests with WskActorSys val (out, err) = withActionContainer() { c => val (initCode, initRes) = c.init(initPayload(code, main = "main")) if (initErrorsAreLogged) { - initCode should be(200) - val args = JsObject("msg" -> JsString("any")) - val (runCode, runRes) = c.run(runPayload(args)) - runCode should be(502) + initCode should be(502) Review comment: Thanks @silvasong for the clarification. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services