From issues-return-35196-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Fri Mar 8 22:59:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 46E7A18067C for ; Fri, 8 Mar 2019 23:59:57 +0100 (CET) Received: (qmail 50033 invoked by uid 500); 8 Mar 2019 22:59:56 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 50020 invoked by uid 99); 8 Mar 2019 22:59:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2019 22:59:56 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: [GitHub] [incubator-openwhisk] dubee commented on a change in pull request #4328: Set API key annotation for a WskConsole test Message-ID: <155208599587.10979.12623321207667648707.gitbox@gitbox.apache.org> Date: Fri, 08 Mar 2019 22:59:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dubee commented on a change in pull request #4328: Set API key annotation for a WskConsole test URL: https://github.com/apache/incubator-openwhisk/pull/4328#discussion_r263958597 ########## File path: tests/src/test/scala/system/basic/WskConsoleTests.scala ########## @@ -88,7 +90,10 @@ abstract class WskConsoleTests extends TestHelpers with WskTestHelpers { it should "show repeated activations" in withAssetCleaner(wskprops) { (wp, assetHelper) => val name = withTimestamp("countdown") assetHelper.withCleaner(wsk.action, name) { (action, _) => - action.create(name, Some(TestUtils.getTestActionFilename("countdown.js"))) + action.create( + name, + Some(TestUtils.getTestActionFilename("countdown.js")), + annotations = Map(WhiskAction.provideApiKeyAnnotationName -> JsBoolean(true))) Review comment: @rabbah, the test suite is an abstract class. I don't believe this suite gets ran outside of the CLI repo. Which explains why it did not fail anywhere else. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services