openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk] dubee commented on a change in pull request #4344: add name of missing action in sequenceComponentNotFound error
Date Thu, 14 Mar 2019 20:36:43 GMT
dubee commented on a change in pull request #4344: add name of missing action in sequenceComponentNotFound
error
URL: https://github.com/apache/incubator-openwhisk/pull/4344#discussion_r265755871
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/Actions.scala
 ##########
 @@ -660,7 +660,7 @@ trait WhiskActionsApi extends WhiskCollectionAPI with PostActionActivation
with
       case _: TooManyActionsInSequence => Future failed RejectRequest(BadRequest, sequenceIsTooLong)
       case _: NoComponentInSequence    => Future failed RejectRequest(BadRequest, sequenceNoComponent)
       case _: SequenceWithCycle        => Future failed RejectRequest(BadRequest, sequenceIsCyclic)
-      case _: NoDocumentException      => Future failed RejectRequest(BadRequest, sequenceComponentNotFound)
+      case _: NoDocumentException      => Future failed RejectRequest(BadRequest, s"$sequenceComponentNotFound:
$sequenceAction")
 
 Review comment:
   How about updating `sequenceComponentNotFound` to be a function that has a parameter for
the action name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message