openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk] markusthoemmes commented on a change in pull request #4343: Move runtimesRegistry to pureconfig.
Date Thu, 14 Mar 2019 10:52:09 GMT
markusthoemmes commented on a change in pull request #4343: Move runtimesRegistry to pureconfig.
URL: https://github.com/apache/incubator-openwhisk/pull/4343#discussion_r265511625
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala
 ##########
 @@ -47,6 +47,8 @@ case class ContainerPoolConfig(userMemory: ByteSize, concurrentPeekFactor:
Doubl
   def cpuShare(reservedMemory: ByteSize) = (totalShare / (userMemory.toBytes / reservedMemory.toBytes)).toInt
 }
 
+case class RuntimesRegistryConfig(url: String, user: Option[String] = None, password: Option[String]
= None)
 
 Review comment:
   Should the credentials be their own type which should then be optional? It can get awkward
if you have possibly two optional types but do you really want the case of `Config("bla",
None, Some("password"))`? I'd assume no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message