From issues-return-33571-archive-asf-public=cust-asf.ponee.io@openwhisk.incubator.apache.org Fri Feb 1 05:56:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3174918077F for ; Fri, 1 Feb 2019 06:56:51 +0100 (CET) Received: (qmail 12963 invoked by uid 500); 1 Feb 2019 05:56:50 -0000 Mailing-List: contact issues-help@openwhisk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.incubator.apache.org Delivered-To: mailing list issues@openwhisk.incubator.apache.org Received: (qmail 12939 invoked by uid 99); 1 Feb 2019 05:56:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2019 05:56:49 +0000 From: GitBox To: issues@openwhisk.apache.org Subject: =?utf-8?q?=5BGitHub=5D_rabbah_commented_on_a_change_in_pull_request_=2342?= =?utf-8?q?43=3A_Optional_write_activation_results_to_file=E2=80=A6?= Message-ID: <154900060943.26063.3651366164831848846.gitbox@gitbox.apache.org> Date: Fri, 01 Feb 2019 05:56:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rabbah commented on a change in pull request #4243: Optional write activation results to file… URL: https://github.com/apache/incubator-openwhisk/pull/4243#discussion_r252939929 ########## File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFileStorage.scala ########## @@ -92,8 +93,12 @@ class ActivationFileStorage(logFilePrefix: String, private def transcribeActivation(activation: WhiskActivation, additionalFields: Map[String, JsValue]) = { val transactionType = Map("type" -> "activation_record".toJson) - val message = Map( - "message" -> s"Activation record '${activation.activationId}' for entity '${activation.name}'".toJson) + val message = writeResultToFile match { Review comment: how about plain old if: `if (writeToFile) { ... } else { }` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services