kpavel commented on a change in pull request #4216: Proposing Lean OpenWhisk
URL: https://github.com/apache/incubator-openwhisk/pull/4216#discussion_r253785267
##########
File path: ansible/roles/invoker/tasks/deploy.yml
##########
@@ -26,25 +26,29 @@
# must include a trailing '/'.
#
- name: "pull runtime action images per manifest"
- shell: "docker pull {{runtimes_registry | default()}}{{item.prefix}}/{{item.name}}:{{item.tag
| default()}}"
+ shell: "docker pull {{runtimes_registry | default()}}{{inv_item.prefix}}/{{inv_item.name}}:{{inv_item.tag
| default()}}"
Review comment:
it will clash with "item" from controller deploy.yml
we need to include invoker deploy.yml anyway. either from separate plugin or from "when
lean" section in controller deploy.yml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
|