openwhisk-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rabbah commented on a change in pull request #4216: Proposing Lean OpenWhisk
Date Mon, 04 Feb 2019 16:41:02 GMT
rabbah commented on a change in pull request #4216: Proposing Lean OpenWhisk
URL: https://github.com/apache/incubator-openwhisk/pull/4216#discussion_r253285264
 
 

 ##########
 File path: ansible/roles/controller/tasks/lean.yml
 ##########
 @@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more contributor
+# license agreements; and to You under the Apache License, Version 2.0.
+---
+# This plugin will  provide controller with Lean Controller parameters
+
+- name: set inventory_hostname to invoker and save controllers data that can be changed by
invoker task
+  set_fact:
+    controller_env: "{{ env }}"
+    controller_ports: "{{ ports_to_expose }}"
+    inventory_hostname: "invoker0"
+    invoker_index_base: 0
+    name_prefix: "invoker"
+    host_group: "{{ groups['invokers'] }}"
+
+- name: include invoker data
+  include_tasks: "../invoker/tasks/deploy.yml"
 
 Review comment:
   i think we can avoid doing this too - and remove this whole file.
   the invoker playbook should just run with the `lean` setting --- the only real think it
has to do is pull the runtime images.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message