From dev-return-4571-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Thu Oct 3 09:44:42 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6B20518065B for ; Thu, 3 Oct 2019 11:44:42 +0200 (CEST) Received: (qmail 70355 invoked by uid 500); 3 Oct 2019 09:44:41 -0000 Mailing-List: contact dev-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list dev@openwhisk.apache.org Received: (qmail 70340 invoked by uid 99); 3 Oct 2019 09:44:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Oct 2019 09:44:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BA15BC1E80 for ; Thu, 3 Oct 2019 09:44:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.8 X-Spam-Level: * X-Spam-Status: No, score=1.8 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vh6J7bkcWxiG for ; Thu, 3 Oct 2019 09:44:17 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::d36; helo=mail-io1-xd36.google.com; envelope-from=chetan.mehrotra@gmail.com; receiver= Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id C67D57DE25 for ; Thu, 3 Oct 2019 09:44:16 +0000 (UTC) Received: by mail-io1-xd36.google.com with SMTP id n26so3948552ioj.8 for ; Thu, 03 Oct 2019 02:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Z3J656T6v11LUMJ872QLQKzfdez8/HvbgxjUyDey1Ro=; b=rqGIKw8EQcdYUVqcw5iotcqG+2sf29oIeLz+Bdp3D1rMXXqy+GlyAeSrOLB4Hm9Jve rUB7c4Czfwx+q8CVoOsi3JYqECMRxF/NdZZPNh6Iwso5Hrh4ddSwJCn+QXwwETCKFrqo +A28Jggcd+uqn61d1ejNrpQf+fvYbJXODQkJFXrPE+lELYWDtpMwZhAIdEtRXI5k50rm QRAACU4gJamLH+OUx/pAAEmvgw2bH5mkozEuSdsdk953sPiVn5QBUi7JdkG3OzvnoYl8 DWcRoPrXq0F4hmkGIeM29eFs06Gp/IAjUlttj8f/Evqdb6nz5/CFY42K9NJEXNb9nY8T YpeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Z3J656T6v11LUMJ872QLQKzfdez8/HvbgxjUyDey1Ro=; b=EyrSV2TZy1qre5piUNRSNggzS4TkCP86HWpJZjkEwIvq6HfQ7wUphPwxZC2gXsSP77 l/Zbkg7T+mJBAcgj8HjBf6BalG1MhbVGMuKFXavsyDS/b0VMd5khjyt43TecP9Rh1Fkf 1sUkqGJr8uKEkbays+GDTIB5yRT/BwDTfDnLs2UT8u5d0gh9WUJaZccgIwn36efGJta8 x39e+p/XTmeSJARRUMFXP0AzSSQXOw2IvWKOomdvRMTyBbUt6dolAx4UeBvaonvBlvQk 2r7gYq6YjO/Vr9Sc8FithuWt1yVv1wBIljNoLujv8nDnLoOHRr2eMm83wKJsKySDneOe ZitQ== X-Gm-Message-State: APjAAAW03XXf14oGMxdwRvjcA/Oc8Tnic0XXlQOZq8mUWPz8QbXPT9oH 5udiJzTNnO5cGcjqjFVOp5GAgYkawxaLEtZ1NsHDSkoCKDk= X-Google-Smtp-Source: APXvYqyK0ATuhbHM5JqGOWSmRjMJQOetnz4nHc1V6yK0xLZybOlU8uvgK7PeIVcMao+ZLz/znGAg3rCiHYOjFkdqrDw= X-Received: by 2002:a92:9f99:: with SMTP id z25mr9030300ilk.145.1570095855136; Thu, 03 Oct 2019 02:44:15 -0700 (PDT) MIME-Version: 1.0 From: Chetan Mehrotra Date: Thu, 3 Oct 2019 15:14:03 +0530 Message-ID: Subject: Capturing Activation response size as part of User Events (#4660) To: dev@openwhisk.apache.org Content-Type: multipart/alternative; boundary="000000000000b574280593fe6d93" --000000000000b574280593fe6d93 Content-Type: text/plain; charset="UTF-8" Hi Team, I would like to capture the activation response size as part of user event data. This would allow us to understand the distribution of response size across various invocations. This would be useful input for the Activation Persister Service work (#4632) For this purpose a PR is opened (#4660) which captures the HTTP response string size and makes it part of `ActivationResponse` -> `WhiskActivation` -> `Activation` flow The size could have been computed at `Activation` level only but that would have added the overhead of serializing the response json object to json string. In current used approach the size is pre known when we construct the ActivationResponse Currently with this change a new numeric `size` attribute would get added to the `WhiskActivation` json representation which gets stored in db. Technically we can avoid making it part of persisted json as this value is only needed while constructing the `Activation` instance from in memory `WhiskActivation` instance Questions 1. Is current approach fine 2. Should we avoid persisting the size attribute 3. Or would it be ok to get size by converting the response to json string while constructing Activation instance in UserEvent flow Chetan Mehrotra [1] https://github.com/apache/openwhisk/pull/4632 [2] https://github.com/apache/openwhisk/pull/4660 --000000000000b574280593fe6d93--