openwhisk-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-openwhisk-pluggable-provider] markusthoemmes commented on a change in pull request #3: Fixing numerous issues discovered whilst developing new event source
Date Tue, 04 Jun 2019 11:47:16 GMT
markusthoemmes commented on a change in pull request #3: Fixing numerous issues discovered
whilst developing new event source 
URL: https://github.com/apache/incubator-openwhisk-pluggable-provider/pull/3#discussion_r290255720
 
 

 ##########
 File path: actions/event-actions/changesWebAction.js
 ##########
 @@ -36,7 +36,7 @@ function main(params) {
           common.verifyTriggerAuth(triggerData, false)
             .then(() => EventProvider.validate(params))
             .catch(err => {
-              return reject(common.sendError(400, `Feed parameter validation failed`, err.message));
+              throw common.sendError(400, `Feed parameter validation failed`, err.message);
 
 Review comment:
   Shouldn't this actually be what you had above? `Promise.reject(...)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message