From dev-return-3595-archive-asf-public=cust-asf.ponee.io@openwhisk.apache.org Mon Apr 15 16:47:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 895E118064C for ; Mon, 15 Apr 2019 18:47:15 +0200 (CEST) Received: (qmail 70372 invoked by uid 500); 15 Apr 2019 16:47:14 -0000 Mailing-List: contact dev-help@openwhisk.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openwhisk.apache.org Delivered-To: mailing list dev@openwhisk.apache.org Received: (qmail 70360 invoked by uid 99); 15 Apr 2019 16:47:14 -0000 Received: from ui-eu-01.ponee.io (HELO localhost) (176.9.59.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Apr 2019 16:47:14 +0000 X-Mailer: LuaSocket 3.0-rc1 x-ponymail-agent: PonyMail Composer/0.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Date: Mon, 15 Apr 2019 16:47:12 -0000 To: References: Message-ID: Subject: Re: NodeJS Runtime - An ability to run on Knative along with OpenWhisk x-ponymail-sender: 0fa86a36c3825c8358b8c23bd6394831c78e1a14 In-Reply-To: From: Matt Rutkowski Thanks Priti for your excellent work getting the code under devtools repo. working with Gradle for all Node versions. It is indeed exciting to be at the point where we believe the code is ready for public review. This PR is what we have been discussing and demoing over the last 2 months which showcases the use of a platform factory that can, via the build process, either create the traditional OpenWhisk-native implementation which provides the same, identical code path (i.e., init/run endpoints) we have used since forever or create a Knative impl. which supports supports a single endpoint and furthermore includes HTTP request pre-processing and response post-processing to provide an equivalent function experience where possible. -MR PS thank for all the test cases that are in a sister PR as well. On 2019/04/10 20:58:34, "Priti Desai" wrote: > Hi Whiskers, > > I have created a PR under NodeJS runtime repo with changes to run the > NodeJS OpenWhisk actions on Knative. > > Please refer to the PR here: > > https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/119 > > If you are running the NodeJS runtime on OpenWhisk, please note that there > are NO CHANGES introduced at all. We have added an ability to run on > Knative without making any changes while running on OpenWhisk. > > I have created two more PRs for documentation and tests: > > documentation - > https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/120 > test - > https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/121 > > Please feel free to review/comment on respective PRs. > > Cheers > Priti > > >